Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for github remote repository #121

Closed

Conversation

FlrnFrmm
Copy link
Contributor

Description

Adds new option --github-repository-url <github repository url>. If set, necessary commit preprocessors are added.
These preprocessors replace github issue (#i) and pull request (@i) refrences with the correct markdown links to the corresponding issues & pull requests.

The option can also be set via the environment variable GIT_CLIFF_GITHUB_REPOSITORY_URL.

Motivation and Context

Issue #112

How Has This Been Tested?

With local test repository.
The new option only adds commit preprocessors.
Commit preprocessors exist already and are tested.

Screenshots / Output (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@FlrnFrmm FlrnFrmm requested a review from orhun as a code owner October 16, 2022 19:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 64.30% // Head: 45.51% // Decreases project coverage by -18.79% ⚠️

Coverage data is based on head (0fb53d8) compared to base (0f38960).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #121       +/-   ##
===========================================
- Coverage   64.30%   45.51%   -18.78%     
===========================================
  Files          14       12        -2     
  Lines         801      534      -267     
===========================================
- Hits          515      243      -272     
- Misses        286      291        +5     
Flag Coverage Δ
unit-tests 45.51% <0.00%> (-18.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
git-cliff/src/lib.rs 0.00% <0.00%> (ø)
git-cliff-core/src/config.rs 38.47% <0.00%> (-21.53%) ⬇️
git-cliff/src/changelog.rs 53.47% <0.00%> (-18.39%) ⬇️
git-cliff-core/src/template.rs 65.22% <0.00%> (-14.78%) ⬇️
git-cliff-core/src/repo.rs 50.95% <0.00%> (-7.72%) ⬇️
git-cliff-core/src/commit.rs 91.92% <0.00%> (-3.06%) ⬇️
git-cliff-core/src/command.rs 94.45% <0.00%> (-1.70%) ⬇️
git-cliff-core/src/error.rs
git-cliff-core/tests/integration_test.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Adds new option `--github-repository-url <github repository url>`.
If set, necessary commit preprocessors are added.
These preprocessors replace github issue and pull request refrences
(#i) with the correct markdown links to the corresponding issues &
pull requests.
@FlrnFrmm FlrnFrmm force-pushed the add_option_for_remote_repository_URL branch from f799ff8 to 0fb53d8 Compare October 16, 2022 21:56
@FlrnFrmm
Copy link
Contributor Author

I don't think the docker build failure is related to my PR, right?

@orhun
Copy link
Owner

orhun commented Dec 22, 2022

Closing due to #112 (comment)

@orhun orhun closed this Dec 22, 2022
@friday friday mentioned this pull request Jul 13, 2023
@orhun
Copy link
Owner

orhun commented Dec 26, 2023

This is now possible via remote config and GitHub integration.

@FlrnFrmm FlrnFrmm deleted the add_option_for_remote_repository_URL branch December 26, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants