-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docker): avoid copying volume inside container #142
Conversation
Untested because I have to run out, but this is roughly the approach I took on some other projects adapted for the way this project is laid out. |
Codecov ReportBase: 43.24% // Head: 43.24% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 43.24% 43.24%
=======================================
Files 12 12
Lines 562 562
=======================================
Hits 243 243
Misses 319 319
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks like |
Interesting. We can probably just echo the config to the file in |
@alerque Can you check out if this actually works? |
Kind ping @alerque |
49d350a
to
754b942
Compare
Otherwise any project configs have no chance of being read...
Congrats on merging your first pull request! ⛰️ |
A different way to work around the problems noted in #108, c.f trailing comments in #109.