-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): support placing configuration inside pyproject.toml #147
Conversation
0797bfa
to
061b0b3
Compare
061b0b3
to
64f29ab
Compare
Hello @radusuciu, thanks for the contribution! 🐻
Can you please do that and post results? I think it should work just fine but let's see if there are any sharp edges. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 43.37% 43.48% +0.11%
==========================================
Files 12 12
Lines 558 559 +1
==========================================
+ Hits 242 243 +1
Misses 316 316
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Hi, thanks for being open with contributions! Yes, I will test this on some of my projects and update here. |
Looking forward to it! |
So I tested with a small project of mine and it works as expected in that it produces the same output given a I tested with a second repository, this time with the PDM project. For my fork, see the following files:
Though I am not yet very familiar with Thanks! |
FYI, confirmed working on another project! See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great. Thank you for the PR and detailed testing! 🐻💖
Awesome, thank you! |
Please see #146 for a description. Also please note that this isn't yet tested on an actual repository though if there's interest I can do that.
Types of changes
Checklist: