Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): improve matching gitmoji tip #486

Merged
merged 1 commit into from
Feb 14, 2024
Merged

docs(website): improve matching gitmoji tip #486

merged 1 commit into from
Feb 14, 2024

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Feb 8, 2024

Description

Emojis are hard. The pattern was not matching the certain emojis.

The new pattern fixes the issue by adding the variation selectoru{FE0F}.

Further, this makes the zero-width joiner (u{200D}) optional, matching emojis both with and without the ZWJ.

How Has This Been Tested?

I tested the new pattern on my repo and found out many commits had been skipped: welpo/tabi@1bb3c91

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Emojis are hard. The pattern was not matching the recycling emoji, for some reason.

Adding the variation selector`u{FE0F}` fixes it.

Further, this makes the zero-width joiner (`u{200D}`) optional, matching emojis both with and without the ZWJ.
@welpo welpo requested a review from orhun as a code owner February 8, 2024 00:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4713f64) 41.30% compared to head (9584bb5) 41.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files          15       15           
  Lines        1034     1034           
=======================================
  Hits          427      427           
  Misses        607      607           
Flag Coverage Δ
unit-tests 41.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 0731646 into orhun:main Feb 14, 2024
42 checks passed
@welpo welpo deleted the patch-1 branch February 14, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants