Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): fix authenticating for yarn npm publish #574

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

favna
Copy link
Contributor

@favna favna commented Mar 24, 2024

Description

Follow up from #528 where I made a mistake as noted in #528 (comment)

Motivation and Context

Fix a mistake

How Has This Been Tested?

N.A.

Screenshots / Logs (if applicable)

N.A.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: Continuous delivery

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly. N.A.
  • I have formatted the code with rustfmt. N.A.
  • I checked the lints with clippy. N.A.
  • I have added tests to cover my changes. N.A.
  • All new and existing tests passed. N.A.

@favna favna requested a review from orhun as a code owner March 24, 2024 22:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.27%. Comparing base (c535a01) to head (2903eaa).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files          15       15           
  Lines        1071     1071           
=======================================
  Hits          442      442           
  Misses        629      629           
Flag Coverage Δ
unit-tests 41.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun changed the title ci: fix authenticating for yarn npm publish fix(npm): fix authenticating for yarn npm publish Mar 24, 2024
@orhun orhun merged commit 5a0ce6a into orhun:main Mar 24, 2024
44 checks passed
@favna favna deleted the ci/publish-rc-tags-accordingly branch March 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants