Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(changelog): comply with MD022 and fix minor typos #61

Merged
merged 2 commits into from
Feb 8, 2022
Merged

style(changelog): comply with MD022 and fix minor typos #61

merged 2 commits into from
Feb 8, 2022

Conversation

kenji-miyake
Copy link
Contributor

Description

Resolves #60

  • Comply with MD022
  • Fix minor typos

Motivation and Context

See #60.

How Has This Been Tested?

I checked with grep.

Screenshots / Output (if appropriate):

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Kenji Miyake added 2 commits February 7, 2022 11:32
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested a review from orhun as a code owner February 7, 2022 02:41
@kenji-miyake kenji-miyake mentioned this pull request Feb 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #61 (90b3ec2) into main (e1da611) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   40.90%   41.15%   +0.25%     
==========================================
  Files          13       13              
  Lines         824      824              
  Branches      215      215              
==========================================
+ Hits          337      339       +2     
+ Misses        378      374       -4     
- Partials      109      111       +2     
Impacted Files Coverage Δ
git-cliff-core/src/repo.rs 29.17% <0.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1da611...90b3ec2. Read the comment docs.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun orhun changed the title style: comply with MD022 and fix minor typos style(changelog): comply with MD022 and fix minor typos Feb 8, 2022
@orhun orhun merged commit 0293b28 into orhun:main Feb 8, 2022
@kenji-miyake kenji-miyake deleted the fix-styles branch February 8, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comply with MD022?
3 participants