Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): fix link to github-keepachangelog template #694

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jun 12, 2024

Description

Bringing a quick fix that I noticed while reading the documentation.

Motivation and Context

Seemed like the right thing to do and the same effort as creating an issue.

How Has This Been Tested?

Render the diff in preview and ensuring it works.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tcarmet tcarmet requested a review from orhun as a code owner June 12, 2024 23:00
Copy link

welcome bot commented Jun 12, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.89%. Comparing base (8a9f9f4) to head (4de7fbc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files          18       18           
  Lines        1350     1350           
=======================================
  Hits          498      498           
  Misses        852      852           
Flag Coverage Δ
unit-tests 36.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit eac2195 into orhun:main Jun 13, 2024
43 of 44 checks passed
Copy link

welcome bot commented Jun 13, 2024

Congrats on merging your first pull request! ⛰️

@tcarmet tcarmet deleted the patch-1 branch June 13, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants