Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): clean up some code #709

Merged
merged 9 commits into from
Aug 3, 2024
Merged

refactor(lib): clean up some code #709

merged 9 commits into from
Aug 3, 2024

Conversation

DaniPopes
Copy link
Contributor

Description

Some clean up opportunities I found while reading the code.

No functional changes intended.

Please let me know if breaking changes are a concern for you, I can revert the change to the public API in the core crate.

Motivation and Context

Refactor

How Has This Been Tested?

cargo test + cargo clippy

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DaniPopes DaniPopes requested a review from orhun as a code owner June 15, 2024 20:32
Copy link

welcome bot commented Jun 15, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 1.31579% with 75 lines in your changes missing coverage. Please review.

Project coverage is 37.04%. Comparing base (35b886e) to head (51f5b4d).

Files Patch % Lines
git-cliff/src/lib.rs 0.00% 55 Missing ⚠️
git-cliff-core/src/repo.rs 0.00% 18 Missing ⚠️
git-cliff-core/src/changelog.rs 33.34% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
+ Coverage   36.66%   37.04%   +0.38%     
==========================================
  Files          20       20              
  Lines        1544     1531      -13     
==========================================
+ Hits          566      567       +1     
+ Misses        978      964      -14     
Flag Coverage Δ
unit-tests 37.04% <1.32%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

git-cliff/src/lib.rs Outdated Show resolved Hide resolved
git-cliff/src/lib.rs Outdated Show resolved Hide resolved
git-cliff/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It mostly looks good, the behavior looks like the same. I have some concerns about lib.rs but will double check to make sure.

DaniPopes and others added 4 commits June 24, 2024 20:27
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
@DaniPopes
Copy link
Contributor Author

@orhun should be good now 🙏

git-cliff/src/lib.rs Outdated Show resolved Hide resolved
@orhun orhun changed the title refactor: clean up some code refactor(lib): clean up some code Aug 3, 2024
@orhun orhun merged commit 4b0c0eb into orhun:main Aug 3, 2024
58 checks passed
Copy link

welcome bot commented Aug 3, 2024

Congrats on merging your first pull request! ⛰️

@orhun
Copy link
Owner

orhun commented Aug 3, 2024

Awesome work, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants