-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bump): support bumping to a specific semver type #744
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
hi @orhun this is still a experimental draft that i would like to see if the approach if right to add an option to specify the bump type before i add more tests and documentation this change has similar effect of |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 36.40% 35.89% -0.51%
==========================================
Files 20 20
Lines 1522 1544 +22
==========================================
Hits 554 554
- Misses 968 990 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hi @orhun I wonder if you have taken a look at the pr and can provide some feedback on it. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, thanks for the PR! Had some comments.
@orhun Let me know what do you think : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you add a fixture test as well? I'm guessing you can simply grab one of the test-bump-version
ones and edit it accordingly.
No problem. Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.
Congrats on merging your first pull request! ⛰️ |
Description
Support bumping to a specific semver type with
--bump major/minor/patch
Motivation and Context
Allow user bumping the version by specifying the type including major, minor and patch
How Has This Been Tested?
Screenshots / Logs (if applicable)
Types of Changes
Checklist: