Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): allow using --bumped-version without conventional commits #806

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Aug 21, 2024

Motivation and Context

fixes #805

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.71%. Comparing base (a71649b) to head (527d772).

Files Patch % Lines
git-cliff-core/src/config.rs 57.15% 3 Missing ⚠️
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   39.61%   39.71%   +0.10%     
==========================================
  Files          20       20              
  Lines        1606     1607       +1     
==========================================
+ Hits          636      638       +2     
+ Misses        970      969       -1     
Flag Coverage Δ
unit-tests 39.71% <50.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit e74080c into main Aug 22, 2024
58 of 59 checks passed
@orhun orhun deleted the fix/initial_tag_with_no_releases branch August 22, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--bumped-version does not return initial_tag if there are no conventional commits in the history.
2 participants