Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fixtures): build binaries using dev profile #886

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Sep 25, 2024

Description

Motivation and Context

Should speed up CI since every fixture test builds its own git-cliff binary; an alternative would be to have a separate job that installs the binary and make all the fixture jobs depend on it.

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DaniPopes DaniPopes requested a review from orhun as a code owner September 25, 2024 14:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.04%. Comparing base (8b7c200) to head (52cd15a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   40.04%   40.04%           
=======================================
  Files          21       21           
  Lines        1671     1671           
=======================================
  Hits          669      669           
  Misses       1002     1002           
Flag Coverage Δ
unit-tests 40.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniPopes
Copy link
Contributor Author

Before:

image

After:

image

~3 min to ~1 min; the larger total duration is due to ratelimiting since I also had triggered the CI in #711 at the same time.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks a lot!

@orhun orhun changed the title chore(ci): build binaries using dev profile chore(fixtures): build binaries using dev profile Sep 25, 2024
@orhun orhun merged commit a394f88 into orhun:main Sep 25, 2024
63 checks passed
@DaniPopes DaniPopes deleted the ci-dev branch September 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants