-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remote): preserve first time contributors #925
Conversation
I'm pretty very new to rust and I'm not entirely sure what I've done around date parsing is correct. Feedback very welcome |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 41.57% 41.98% +0.41%
==========================================
Files 21 21
Lines 1677 1694 +17
==========================================
+ Hits 697 711 +14
- Misses 980 983 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'll look at test coverage as well. |
Thanks for the PR! I will be reviewing this soon. No need to worry about test coverage or the code style for now. Can you also update |
Updated the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The behavior seems to be fixed 👌🏼
I have one little comment.
- add test for timestamp method as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! ❤️
Description
Preserve first time contributors in older change logs
Fixes #891
Motivation and Context
When a new release is created and all change logs regenerated the first time contributor section is removed.
How Has This Been Tested?
Tested using existing fixtures.
Types of Changes
Checklist: