Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for popup menu #1576

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Fix for popup menu #1576

merged 9 commits into from
Aug 17, 2022

Conversation

jokd
Copy link
Contributor

@jokd jokd commented Aug 3, 2022

Fixes #1558
Cleaned up a bit, hopefully didn't mess up anything

@jokd jokd changed the title Rewrote a bit Fix for popup menu Aug 3, 2022
@Grammostola
Copy link
Contributor

Hi, it seems to work as intended now, i,e sticks with the legend when the legend is scrolled and doesn't re-open in the same place as last place but rather always somewhat above the three dots, very much an improvement. Would it be possible to slightly reduce the distance above the three dots that it opens at?

@jokd
Copy link
Contributor Author

jokd commented Aug 8, 2022

Tested now and I can see that the first layer has less margin between the three dots and the menu. Is that distance better?

@jokd
Copy link
Contributor Author

jokd commented Aug 15, 2022

This is ok to test now. Tried different approaches to slide down the menu as well as to position the menu on top of the legend but stuff got messed up no matter what so I think this for now is the least lousy solution without rewriting the legend quite a bit.

@tonnyandersson
Copy link
Collaborator

tonnyandersson commented Aug 15, 2022

LGTM, but I'll let @Grammostola have the final word on this.

@Grammostola
Copy link
Contributor

Looks good to me

@jokd jokd merged commit 64a93c6 into master Aug 17, 2022
@jokd jokd deleted the scroll-fix branch August 17, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling the legend with popup menu expanded
3 participants