-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for popup menu #1576
Fix for popup menu #1576
Conversation
Hi, it seems to work as intended now, i,e sticks with the legend when the legend is scrolled and doesn't re-open in the same place as last place but rather always somewhat above the three dots, very much an improvement. Would it be possible to slightly reduce the distance above the three dots that it opens at? |
Tested now and I can see that the first layer has less margin between the three dots and the menu. Is that distance better? |
This is ok to test now. Tried different approaches to slide down the menu as well as to position the menu on top of the legend but stuff got messed up no matter what so I think this for now is the least lousy solution without rewriting the legend quite a bit. |
LGTM, but I'll let @Grammostola have the final word on this. |
Looks good to me |
Fixes #1558
Cleaned up a bit, hopefully didn't mess up anything