-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Rescale vector tiles depending on dpi in print #1911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rescaling functionality in the olms extension. The extension creates one style for each configured print resolution, which is then applied when said print resolution is chosen.
Remove extensions.js which was mistakenly added from the PR.
jokd
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to test this but it looks good so I suggest we merge it
There are one or two changes incoming |
Created a general method for scaling mapbox vector tiles to avoid duplicated almost identical code. The method is only used if the layer is of format 'mvt' to avoid applying it to regular vector tile layers.
Style-type is now used instead of layer format to determine how to rescale the style of a mapbox vector tile.
Circles in the mapbox vector tile style is now rescaled in the same way as other style elements.
There's a minor niggle with an error when the print preview exits, a default param is given a There are two potential discussion points:
|
Removed null as argument from ScaleMapboxLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The olms extension now rescales mapbox vector tiles when changing the dpi of a print.
The extension creates one style for each configured print resolution, which is then applied when said print resolution is chosen.
Fix for #1801