Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opencollective-postinstall instead of opencollective #263

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Apr 17, 2018

Summary

Use opencollective-postinstall instead of opencollective

Explain the motivation for making this change. What existing problem does the pull request solve?

See #231 (comment)

Requirements

Make sure these boxes are checked:

  • link to an issue
  • tests are updated (added/changed/removed)
  • tests run successfully (local)
  • tests run successfully (TravisCI)
  • please follow this styleguide for this pr title

@orizens
Copy link
Owner

orizens commented Apr 17, 2018

@topaxi after a closer look - it seems like moving opencollective to devDependencies disables the message for contribution when installing ngx-infinite-scroll.

@topaxi
Copy link
Contributor Author

topaxi commented Apr 17, 2018

I see, that is very unfortunate because opencollective pulls in a lot of dependencies :(

@mnahkies
Copy link

mnahkies commented Feb 5, 2019

@topaxi wouldn't these be shaken out of production builds anyway? Still not ideal, but I wouldn't have expected it to affect bundle sizes

@topaxi
Copy link
Contributor Author

topaxi commented Feb 6, 2019

This wasn't about bundle size but installation size. Sometimes one is on the road and wants to develop and being in a train or on some bad mobile or wifi connection the size of packages and amount of dependencies can cripple local installation with npm install a lot.

@anteq
Copy link

anteq commented Feb 11, 2019

Hey, how about substituting opencollective postinstall with opencollective-postinstall? It looks like it's the new recommended package with almost no dependencies. That also prevents "Permission denied" crashes on some CI servers:
opencollective/opencollective-postinstall#15

@topaxi topaxi force-pushed the opencollective-to-dev branch from ddde751 to 5fbc8af Compare February 11, 2019 10:02
@topaxi
Copy link
Contributor Author

topaxi commented Feb 11, 2019

I have updated the PR to use opencollective-postinstall.

@topaxi topaxi changed the title Move opencollective to devDependencies Use opencollective-postinstall instead of opencollective Feb 11, 2019
@orizens orizens merged commit f1ac40e into orizens:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants