Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Microsoft MSSQL to fix init() driver Registration conflicts #1093

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

jrapoport
Copy link
Contributor

The denisenkom go-mssqldb library is outdated and causes a double-registration panic with other libraries that use the newer Microsoft one like Gorm:

func init() {
	registry.Register("mssql", func() gnomock.Preset { return &P{} })
}

Swapped github.com/denisenkom/go-mssqldb for github.com/microsoft/go-mssqldb

(microsoft version looks like a fork of denisenkom and works as a drop in replacement -- tests pass)

@orlangure orlangure merged commit 0f475bb into orlangure:master Nov 3, 2024
24 checks passed
@orlangure
Copy link
Owner

Thank you for fixing this!

@jrapoport
Copy link
Contributor Author

my pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants