Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force version reset #25

Merged
merged 14 commits into from
Jul 4, 2020
Merged

Force version reset #25

merged 14 commits into from
Jul 4, 2020

Conversation

orlowdev
Copy link
Owner

@orlowdev orlowdev commented Jul 3, 2020

Description

Add support for forcing version to reset if prefix changed. This is only applicable for projects with a major version of 1 and higher (public API declared). This option will force public release on the next version bump if prefix changes.

Motivation and Context

To add support for Calendar Versioning (e.g. 2020.1) in the future. The guide for setting up CalVer will be added as soon as #12 is done.

This PR also fixes a couple of bugs found in the process.

Closes #24
Closes #12

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Security fix(non-breaking change which fixes a security issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@orlowdev orlowdev added the enhancement New feature or request label Jul 3, 2020
@orlowdev orlowdev self-assigned this Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           41        41           
  Branches         1         1           
=========================================
  Hits            41        41           
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/utils/helpers.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21758d...9c819b7. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Jul 3, 2020

Code Climate has analyzed commit 9c819b7 and detected 0 issues on this pull request.

View more on Code Climate.

@orlowdev orlowdev merged commit b738a24 into master Jul 4, 2020
@orlowdev orlowdev deleted the force-version-reset branch July 4, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add forcing major version reset on prefix change Add support for trimming trailing zeroes
1 participant