DIC: Use of "RequestStack" instead "Request" (Symfony 2.4) #10
Conversation
grizzlylab
commented
May 15, 2014
grizzlylab
commented
- Do not use the scope "request" anymore.
- Use "RequestStack" instead "Request" in AkismetReal.php.
- Update composer.json to require Symfony 2.4.
| "kriswallsmith/buzz" : "*" | ||
|
|
||
| "kriswallsmith/buzz" : "*", | ||
| "symfony/symfony": "2.4.*" |
There was a problem hiding this comment.
not 2.4.* but ~2.4 to allow newer versions (2.5 for instance).
And requiring symfony/symfony forbids people to install components and bundles they need only instead of the fullstack framework. Ideally, only projects should depend on symfony/symfony. Reusable packages should require the individual packages, to keep the flexikility for projects
|
It would be better to keep the support of the 2.3 LTS in the bundle too. |
|
About Symfony 2.3 LTS, Ornicar should set two branches (one for 2.3 LTS and one dev-master for ~2.4) right ? |
|
Well, maintaining 2 branches of a bundle is more work. Given that @ornicar is not really active in the PHP community anymore, it would be a bad setup to double the maintenance work by dealing with 2 maintained branches. It is possible to support both 2.3 and 2.4 at the same time in the code here (Symfony itself does it in some listeners) |
