Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enforce Wall across the whole codebase #2766

Closed
3 tasks done
vicentebolea opened this issue Jun 16, 2021 · 0 comments
Closed
3 tasks done

CI: Enforce Wall across the whole codebase #2766

vicentebolea opened this issue Jun 16, 2021 · 0 comments
Assignees
@vicentebolea

Comments

@vicentebolea
Copy link
Collaborator

vicentebolea commented Jun 16, 2021 •
edited
Loading

Description

In this task we attempt to enforce good code hygiene through enabling and enforce -Wall through out the CI.

Since it is a big task, the work is spitted into multiple PRs:
@vicentebolea vicentebolea self-assigned this Jun 16, 2021
@vicentebolea vicentebolea mentioned this issue Jun 18, 2021
Merged
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jun 18, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
cb53bc3 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jun 21, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
2aa6858 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jun 21, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
43ddf92 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 6, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
661db37 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 6, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
4d1af25 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 6, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
ffbb06a 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 14, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
cac97c6 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 14, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
a4eaef4 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 16, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
f989ffb 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Jul 16, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
e62045c 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Aug 2, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
b61d034 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Aug 2, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
7f74196 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Aug 2, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
5778398 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this issue Aug 2, 2021
@vicentebolea
CI: Enforce -Wall and -Werror
c25d68c 
Part 2 of: ornladios#2766

Followup of https://github.com/ornladios/ADIOS2/pull/2639/files

Notes from this PR:

Wall -Werror enabled for C++ in all builds but:

1. Accent + XL builds
2. Power8 builds
3. Debian buids
4. Using intel compiler translation units that include `nlohmann_json`

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
@vicentebolea vicentebolea mentioned this issue Aug 5, 2021
Merged
@vicentebolea vicentebolea changed the title CI: Treating warning as errors CI: Enforce Wall across the whole codebase Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vicentebolea vicentebolea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicentebolea