Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake option to disable profiling stubs #1410

Merged
merged 9 commits into from
May 14, 2019

Conversation

philip-davis
Copy link
Collaborator

@philip-davis philip-davis commented May 13, 2019

Add the ADIOS2_USE_Profiling option for cmake. If enabled, this defines ADIOS2_HAVE_PROFILING, which the stubs can use to enable generating profile data, e.g. the tau stubs now define TAU_USE_STUBS if ADIOS2_HAVE_PROFILING is defined.

Profiling is enabled by default, if we are doing a shared build. I'm not sure either the default behavior, or the condition, are the right things to do.

Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable approach...

@philip-davis philip-davis merged commit a7d0ab9 into ornladios:master May 14, 2019
@philip-davis philip-davis deleted the profiling-enable branch May 15, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants