Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1577 Pr/fix hdf5 msvc #1587

Merged
merged 3 commits into from
Jun 30, 2019
Merged

fix #1577 Pr/fix hdf5 msvc #1587

merged 3 commits into from
Jun 30, 2019

Commits on Jun 30, 2019

  1. fix HDF5Reader build with MSVC 

    Sadly, variable-sized stack arrays are only a feature of C99, but not C++11,
so this patch uses std::vector instead.
    @germasch
    germasch committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    e945ae8 View commit details
    Browse the repository at this point in the history

  2. msvc: fix some more msvc complaints 

    including use of `uint` and more stack-allocated arrays
    @germasch
    germasch committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    cfc18a2 View commit details
    Browse the repository at this point in the history

  3. msvc: fix remaining VLA arrays 

    I should have gotten them all now via `-Werror=vla` (with clang)
    @germasch
    germasch committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    6fe4dbf View commit details
    Browse the repository at this point in the history