Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python/layout #1668

Closed
wants to merge 17 commits into from
Closed

python/layout #1668

wants to merge 17 commits into from

Commits on Aug 12, 2019

  1. delete a bunch of superfluous semicolons

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    4647767 View commit details
    Browse the repository at this point in the history

  2. python/hl: add tests covering high-level read API 

    This is to take account of what currently works and how, vs what does
not.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    97801fa View commit details
    Browse the repository at this point in the history

  3. python/hl: avoid a bunch of casts

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    857a8eb View commit details
    Browse the repository at this point in the history

  4. python/hl: introduce DoRead for (..., start, count, ...) overload

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    9febae7 View commit details
    Browse the repository at this point in the history

  5. python/hl: avoid 2nd round of dispatch by callig DoRead() directly

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    a2201f2 View commit details
    Browse the repository at this point in the history

  6. python/hl: allow empty start, count arguments 

    Where empty start means, start at the origin (0, 0, ...), and
empty count means, cover the whole array

This correspondingly simplifies the preceding DoRead() a bit,
but it also allows to pass empty start, count args from python
directly.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    d91106f View commit details
    Browse the repository at this point in the history

  7. python/hl: move figuring default count down into next DoRead()

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    9d8dbb9 View commit details
    Browse the repository at this point in the history

  8. python/hl: handle GlobalValue down in next DoRead()

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    2ffef30 View commit details
    Browse the repository at this point in the history

  9. python/hl: get rid of first DoRead(), and mostly Read() 

    I was hoping to get rid of it entirely, but since people may be using
those functions with positional arguments, I need to keep the old
signature.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    808a0d6 View commit details
    Browse the repository at this point in the history

  10. python/hl: mv implementation of step selection case -> DoRead()

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    a135bad View commit details
    Browse the repository at this point in the history

  11. python/hl: mv up handling of SetBlockSelection

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    f6c9b14 View commit details
    Browse the repository at this point in the history

  12. python/hl: mv up handling of GlobalValue; call SetSelection directly

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    c71f6f7 View commit details
    Browse the repository at this point in the history

  13. python/hl: simplify setting of count 

    since for GlobalArrays, when a Variable is created, count is defaulted
to shape already.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    d8445f0 View commit details
    Browse the repository at this point in the history

  14. python/hl: merge to only one version of DoRead

    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    31a4585 View commit details
    Browse the repository at this point in the history

  15. layout: introduce print_shape() helper in bpls 

    Which will be used to print information whether the dims are reversed.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    ee89bd6 View commit details
    Browse the repository at this point in the history

  16. layout: implement GetOriginalLayout() 

    It doesn't actually work, since there are no blocks avalable
that we could use to look at IsReverseDims.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    2e23fa5 View commit details
    Browse the repository at this point in the history

  17. layout: fix the stepSelection case with row-major data 

    This is kinda tricky -- the goal is the user is able to work with the
data without knowing it's original storage order, and this achieves
that, though it requires a custom stride calculation.
    @germasch
    germasch committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    851ef61 View commit details
    Browse the repository at this point in the history