Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactored bindings #281

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
85488ca
Initial re-work of ADIOS, IO, and Variable python bindings.
Sep 26, 2017
f91161a
Add an addition helper macro for preprocessor stringification.
Sep 28, 2017
e3fc2c0
Add some additional get/set functionality to IO
Sep 28, 2017
ead0cda
More types
Sep 29, 2017
e0cc08d
Fix missing stl include
Sep 29, 2017
e24d633
Mane python dependency search aware of PYTHON env var
Oct 2, 2017
1391392
bunches of updates
Oct 6, 2017
249c877
Get the python wrapping test working again
scottwittenburg Oct 6, 2017
197799a
Add a python interpreter, an instance helper, and a new engine type
scottwittenburg Oct 6, 2017
89f1a55
Lots of changes to get things working, and we're still not there
scottwittenburg Oct 6, 2017
457ae76
Remove Engine friendship, move PyEngineBase into adios2, make DoWrite…
scottwittenburg Oct 9, 2017
bcfc4da
Forward the rest of the Engine api methods to the python instance
scottwittenburg Oct 9, 2017
0b88c03
Put back the python tests, make Engine::Close default arg work, etc...
scottwittenburg Oct 10, 2017
6b415f2
Rename PythonInstanceBuilder to PythonModuleHelper
scottwittenburg Oct 10, 2017
59cf9de
Address issues importing modules within the embedded interpreter
scottwittenburg Oct 10, 2017
4681c74
If PYTHONHOME is set at run time, use it instead of dladdr approach
scottwittenburg Oct 11, 2017
cc4236f
Make sure mpi tests run on osx, fix bpwritetypes mpi-mode test
scottwittenburg Oct 11, 2017
f1f2979
Add one more python test, remove some cmake messages, etc...
scottwittenburg Oct 11, 2017
d2e8bd2
Fix broken test
scottwittenburg Oct 11, 2017
3c82546
Add site-packages define to the generate function
scottwittenburg Oct 11, 2017
5ad83c3
Clang formatting
scottwittenburg Oct 11, 2017
05a23f1
Flake8 style fixes
scottwittenburg Oct 11, 2017
f498d74
Couple of minor tweaks
scottwittenburg Oct 11, 2017
dd8179a
Try to get python enabled on Windows (VS2017 only)
scottwittenburg Oct 17, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions bindings/python/ADIOSPy.cpp

This file was deleted.

48 changes: 0 additions & 48 deletions bindings/python/ADIOSPy.h

This file was deleted.

29 changes: 13 additions & 16 deletions bindings/python/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,34 +1,31 @@
pybind11_add_module(adios2py MODULE
ADIOSPy.h
ADIOSPy.cpp
adiosPyFunctions.h
adiosPyFunctions.cpp
adiosPyTypes.h
EnginePy.h
EnginePy.inl
EnginePy.cpp
gluePyBind11.cpp
IOPy.h
IOPy.cpp
VariablePy.h
VariablePy.cpp
adios2py.cpp
PyAttribute.cpp
PyADIOS.cpp
PyEnums.cpp
PyEngine.cpp
PyIO.cpp
PyVariable.cpp
)
target_include_directories(adios2py PRIVATE ${ADIOS2_SOURCE_DIR}/source/adios2/engine/pyengine)
target_link_libraries(adios2py PRIVATE adios2)
if(ADIOS2_HAVE_MPI)
target_link_libraries(adios2py PRIVATE PythonModule::mpi4py)
endif()

string(REGEX REPLACE
"^${PYTHON_PREFIX}/[^/]*/python" "${CMAKE_INSTALL_LIBDIR}/python"
CMAKE_INSTALL_PYTHONDIR "${PYTHON_SITE_PACKAGES}"
set(PY_VERSION_STRING "${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.${PYTHON_VERSION_PATCH}")
set(CMAKE_INSTALL_PYTHONDIR
"${CMAKE_INSTALL_LIBDIR}/python${PY_VERSION_STRING}/site-packages"
)
set(CMAKE_INSTALL_PYTHONDIR "${CMAKE_INSTALL_PYTHONDIR}"
CACHE INTERNAL "" FORCE
)
message(" ******** adios2py output directory: ${ADIOS2_BINARY_DIR}/${CMAKE_INSTALL_PYTHONDIR}")
set_target_properties(adios2py PROPERTIES
OUTPUT_NAME adios2
LIBRARY_OUTPUT_DIRECTORY ${ADIOS2_BINARY_DIR}/${CMAKE_INSTALL_PYTHONDIR}
RUNTIME_OUTPUT_DIRECTORY ${ADIOS2_BINARY_DIR}/${CMAKE_INSTALL_PYTHONDIR}
ARCHIVE_OUTPUT_DIRECTORY ${ADIOS2_BINARY_DIR}/${CMAKE_INSTALL_PYTHONDIR}
)
install(TARGETS adios2py
DESTINATION ${CMAKE_INSTALL_PYTHONDIR}
Expand Down
67 changes: 0 additions & 67 deletions bindings/python/EnginePy.cpp

This file was deleted.

58 changes: 0 additions & 58 deletions bindings/python/EnginePy.h

This file was deleted.

43 changes: 0 additions & 43 deletions bindings/python/EnginePy.inl

This file was deleted.

76 changes: 0 additions & 76 deletions bindings/python/IOPy.cpp

This file was deleted.

Loading