Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax fix in declarations for C++20 compliance #3145

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Syntax fix in declarations for C++20 compliance #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bindings/CXX11/adios2/cxx11/Attribute.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ class Attribute
* attributes from IO:DefineAttribute<T> or IO:InquireAttribute<T>.
* Can be used with STL containers.
*/
Attribute<T>() = default;
~Attribute<T>() = default;
Attribute() = default;
~Attribute() = default;

/** Checks if object is valid, e.g. if( attribute ) { //..valid } */
explicit operator bool() const noexcept;
Expand Down Expand Up @@ -74,7 +74,7 @@ class Attribute
bool IsValue() const;

private:
Attribute<T>(core::Attribute<IOType> *attribute);
Attribute(core::Attribute<IOType> *attribute);
core::Attribute<IOType> *m_Attribute = nullptr;
};

Expand Down
6 changes: 3 additions & 3 deletions bindings/CXX11/adios2/cxx11/Variable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ class Variable
* variables from IO:DefineVariable<T> or IO:InquireVariable<T>.
* Can be used with STL containers.
*/
Variable<T>() = default;
Variable() = default;

/** Default, using RAII STL containers */
~Variable<T>() = default;
~Variable() = default;

/** Checks if object is valid, e.g. if( variable ) { //..valid } */
explicit operator bool() const noexcept;
Expand Down Expand Up @@ -389,7 +389,7 @@ class Variable
using Span = adios2::detail::Span<T>;

private:
Variable<T>(core::Variable<IOType> *variable);
Variable(core::Variable<IOType> *variable);
core::Variable<IOType> *m_Variable = nullptr;

std::vector<std::vector<typename Variable<T>::Info>> DoAllStepsBlocksInfo();
Expand Down