Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: major rework for image generations of GHA #3331

Merged
merged 1 commit into from
Sep 10, 2022
Merged

CI: major rework for image generations of GHA #3331

merged 1 commit into from
Sep 10, 2022

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Aug 30, 2022 •
edited
Loading

CI: major rework for image generations of Github Actions builds.

  • It adds Kokkos CUDA.
  • It sets the CMAKE version to 3.22.4.
  • It leverages in Spack Environments to install the dependencies needed for the builds
  • In the CUDA image, we install CUDA in Spack rather than using the CUDA rockylinux image.
  • It reduces the amount of intermediate images.
  • It introduces pyexpand templates to easily modify packages and versions per each build in the future wihouth changing the dockerfiles and shell scrips.

@vicentebolea vicentebolea changed the title CI: add kokkos to mpich build CI: add kokkos to CUDA build Aug 30, 2022
anagainaru
anagainaru reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@anagainaru anagainaru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to load kokkos without the wrapper. Did you say you were getting errors?

I haven't tested yet, but ADIOS2 and Kokkos need to both be build with the nvcc wrapper or both without.

scripts/ci/images-v2/build-cuda.sh Outdated Show resolved Hide resolved
@vicentebolea vicentebolea force-pushed the add-kokkos-cuda branch 3 times, most recently from 6fc1e6d to 569ff84 Compare September 7, 2022 22:34
@vicentebolea vicentebolea force-pushed the add-kokkos-cuda branch 3 times, most recently from a2e029f to f0aa89d Compare September 8, 2022 20:25
@vicentebolea vicentebolea self-assigned this Sep 8, 2022
@vicentebolea vicentebolea changed the title CI: add kokkos to CUDA build CI: major rework for image generations of GHA Sep 9, 2022
@vicentebolea vicentebolea force-pushed the add-kokkos-cuda branch 2 times, most recently from 3304c35 to 7973b92 Compare September 9, 2022 20:37
@vicentebolea vicentebolea marked this pull request as ready for review September 9, 2022 20:43
@vicentebolea vicentebolea force-pushed the add-kokkos-cuda branch 5 times, most recently from 962c468 to 560010d Compare September 10, 2022 00:35
@vicentebolea
Copy link
Collaborator Author

Merging without review since these are CI changes about the images and many iterations are expected. The images are already deployed and working

@vicentebolea vicentebolea merged commit 2ede8d3 into ornladios:master Sep 10, 2022
@vicentebolea vicentebolea deleted the add-kokkos-cuda branch September 10, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagainaru anagainaru anagainaru left review comments

Assignees

@vicentebolea vicentebolea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicentebolea @anagainaru