Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdf5 vol support will require latest hdf5 1.14 #3516

Merged
merged 5 commits into from
Mar 2, 2023

Conversation

guj
Copy link
Contributor

@guj guj commented Mar 1, 2023

No description provided.

@guj guj requested a review from vicentebolea as a code owner March 1, 2023 22:03
Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; few comments removals; forwarding return code;

source/h5vol/H5Vol_dataset.c Outdated Show resolved Hide resolved
source/h5vol/H5Vol_dataset.c Outdated Show resolved Hide resolved
source/h5vol/H5Vol_dataset.c Outdated Show resolved Hide resolved
source/h5vol/H5Vol_dataset.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@guj guj enabled auto-merge March 2, 2023 21:32
@guj guj disabled auto-merge March 2, 2023 21:32
@guj
Copy link
Contributor Author

guj commented Mar 2, 2023

Looks good :)

Thanks. Not sure why merge is blocked though.

@vicentebolea
Copy link
Collaborator

Looks good :)

Thanks. Not sure why merge is blocked though.

It seems to be waiting of CI to pass

@guj guj merged commit df38d8a into ornladios:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants