Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Put/Get to receive Kokkos Views with HIP backend #3571

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

anagainaru
Copy link
Contributor

This is not a bug, more of an oversight (we don't need this in the current release).

I tested the Kokkos backend in ADIOS2 with HIP on Crusher and it works fine as long as we pass the pointer (i.e. view.data()). I forgot to add the HIP memory space in the part of ADIOS2 that allows submitting directly the Kokkos::View. This PR fixes that.

Tested on Crusher BP4/BP5.

@anagainaru
Copy link
Contributor Author

@vicentebolea I am using hipcc to compile ADIOS2 so we can use the HIP backend in Kokkos. So far it works on Crusher just fine (even with Kokkos 4.0). You might want to add your enable_language section in CMakeLists.txt and see if it still works.

@anagainaru anagainaru merged commit f102c60 into ornladios:master Mar 31, 2023
@anagainaru anagainaru added this to the v2.9.1 milestone Mar 31, 2023
@anagainaru
Copy link
Contributor Author

@vicentebolea this will have to go in the patch for release_29. Should I mark it somehow so we don't forget about it?

vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Apr 27, 2023
Allowing Put/Get to receive Kokkos Views with HIP backend

(cherry picked from commit f102c60)
vicentebolea added a commit that referenced this pull request Apr 27, 2023
* release_29:
  Merge pull request #3571 from anagainaru/hip-adios-view
@vicentebolea
Copy link
Collaborator

@anagainaru backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants