Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in documentation #4166

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

anagainaru
Copy link
Contributor

It was pointed out to me that the build documentation in readthedocs does not work. One typo was:

cmake ../ADIOS2 -DADIOS2_BUILD_EXAMPLES=ON

and second, it wasn't clear that they need to provide an install path based on our instructions (so adios2 doesn't get installed in \usr\local.

@eisenhauer eisenhauer merged commit 5499b23 into ornladios:master May 17, 2024
15 checks passed
@anagainaru anagainaru deleted the typo-build-doc branch May 18, 2024 00:29
@eisenhauer eisenhauer added this to the v2.10.1 milestone May 28, 2024
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request May 28, 2024
vicentebolea added a commit that referenced this pull request May 29, 2024
* release_210:
  Bump version to v2.10.1
  Kill outdated reference to bindings.Mode.ReadFlattenSteps (#4185)
  fix: make changes from #4160 abi compat
  fix: make changes from #4144 abi compat
  Remove special ReadFlattenSteps Mode, switch to control by writer-sid… (#4160)
  EVPath 2024-05-27 (45471c87) (#4181)
  Add API call to reset memory selection (#4169)
  Typo in the build command inside the documentation (#4166)
  Merge pull request #4161 from anagainaru/derived-performance
  Minor docs tweaks (#4153)
  ReadModeFlatten (#4147)
  Merge pull request #4142 from vicentebolea/fix-pugixml-dep
  Fixes for FreeBSD, including upstream (#4138)
  Deactivate campaign recording by default. Use .adios-campaign/ as directory name.
  test CI fix (#4177)
  - based on char signess in installed adios library, use numpy.int8 or numpy.uint8 to read char arrays from BP files - move char as last type in adios type macros, so that unsigned char always becomes uint8_t and signed char becomes int8_t in output (char arrays still become  char in output) - add C++ test to write and read char/signed char/unsigned char arrays
  dill 2024-04-04 (55420dee) (#4136)
  pugixml: correct target name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants