Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply manually Greg's fix for windows to compile the hdf5SubFile exam… #4175

Closed

Conversation

pnorbert
Copy link
Contributor

…ple.

Original fix is found in PR #4167 to master.

@pnorbert pnorbert added this to the v2.10.1 milestone May 23, 2024
@pnorbert pnorbert requested a review from eisenhauer May 23, 2024 18:55
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might also work with just removing unistd.h because I don't think it's needed, but I'm not certain.

… fix-hdf5Subfile-windows

* 'fix-hdf5Subfile-windows' of github:pnorbert/ADIOS2:
  Apply manually Greg's fix for windows to compile the hdf5SubFile example. Original fix is found in PR ornladios#4167 to master.
@pnorbert pnorbert closed this May 23, 2024
@pnorbert
Copy link
Contributor Author

Close this without merge because don't know what is happening to CI

@pnorbert pnorbert deleted the fix-hdf5Subfile-windows branch May 23, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants