-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API to allow storing only stats for primary variables #4328
Conversation
034ad0e
to
6b5a5a9
Compare
6b5a5a9
to
4bf61be
Compare
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the function name does not convey what it is about. How about an inverse approach, like SetStoreMetadataOnly(bool)?
One thing is missing though, the new python API in python/adios2/variable.py. New tests should just use that, which will exercise the adios2.bindings indirectly as well.
810bb5c
to
e26d709
Compare
Co-authored-by: Greg Eisenhauer <eisen@cc.gatech.edu>
0711403
to
1fc22d0
Compare
Co-authored-by: Norbert Podhorszki <pnorbert@ornl.gov>
3436574
to
8a99b4d
Compare
@pnorbert this is ready for review. |
Just an idea: sometime feels better to have |
Normally I would agree, but in this case I don't want users to be able to turn on and off. We either store only stats or we store everything. We talked about the API and decided we do not want to change the |
I believe he meant the same functionality just changing syntax from having a bool argument to separate functions. Graphics packages are full of these. I don't feel better, however, seeing that in adios as a first. |
Add a bool in
VariableBase
to control what we write and corresponding APIs for CXX, C, Python, Fortran.CXX API
varI32.StoreStatsOnly(true);
C bindings:
Fortran bindings:
Python bindings
The reader can inquire variables and get stats about each block but will not be able to read data. A
std::runtime_error
exception will be thrown if data is read for aStatsOnly
variable.