-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing for structs using Kokkos Views #4369
Conversation
f26d432
to
f4e2161
Compare
f4e2161
to
b3a60d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that struct support seems to work without having to change internals!
I am re-running the sanitizers, this might disappear so I am writing it here so we don't miss it.
|
I suspect that there is a race condition associated with this the OnDemand request queue. I'm guessing that it only happens when on the last step the metadata going to reader crosses paths with the request coming from the reader to the writer. If we had another step on the writer, we'd notice in EndStep that we had this request and it was no longer useful, but since it's the last step we fall through into Close() and don't properly deallocate the request. I'll create an issue about it... |
Adding a test that writes and reads a 2D array of particles.
Test passes on HIP/CUDA/CPU backends. We only test writing and reading on the same memory space.