Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly fix leak when an ondemand request comes in just before close #4373

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Possibly fix leak when an ondemand request comes in just before close #4373

merged 1 commit into from
Oct 18, 2024

Conversation

eisenhauer
Copy link
Member

Hopefully address issue #4371 .

@eisenhauer eisenhauer enabled auto-merge (squash) October 17, 2024 23:36
anagainaru
anagainaru approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks acceptable, too bad this is not an error that occurs all the time to make sure it's fixed.

@eisenhauer eisenhauer merged commit 79f6efe into ornladios:master Oct 18, 2024
37 of 38 checks passed
@eisenhauer
Copy link
Member Author

It looks acceptable, too bad this is not an error that occurs all the time to make sure it's fixed.

Yeah, it would take a more complex distributed-system-style test environment to ensure correctness here.

@eisenhauer eisenhauer deleted the Race branch October 18, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagainaru anagainaru anagainaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eisenhauer @anagainaru