Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/onnx models mlflow upload #101

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Conversation

AlessandroPolidori
Copy link
Contributor

@AlessandroPolidori AlessandroPolidori commented Jan 31, 2024

Summary

Describe the purpose of the pull request, including:

Now mlflow model log is optional (regulated by new core config parameter "upload_models").
Now also onnx and onnx simplified models can be logged on mlflow.
Now matplotlib backend is switched to 'Agg' during analysis report image plotting, to solve major slowdown issue on some machines.
Now also Segmentation prints number of samples of each split (without considering classes, given the one-hot encoding ugly format)

Type of Change

  • New feature (non-breaking change that adds functionality)
  • Small Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.
    image

Copy link
Contributor

@lorenzomammana lorenzomammana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job, just a tiny comment

quadra/configs/core/default.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@lorenzomammana lorenzomammana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzomammana lorenzomammana merged commit ccd6566 into main Feb 5, 2024
2 checks passed
@lorenzomammana lorenzomammana deleted the feat/onnx-models-mlflow-upload branch February 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants