Bug: non squared input images break SklearnClassification task #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the purpose of the pull request, including:
Non squared input images currently brake sklearn classification task in two ways:
1- torchscript export fails
2- gradcam fails
1-?
2- Now mask is reconstructed correctly even when width and height are different.
1- I have not tried to solve this problem yet.
2- The mask adjustment is not a trivial task. The reshape() function needs integers, so you need to find two values, height and width, such that w*h = total_size of the mask. But there is no way to know a priori how to truncate height and width values. The solution that satisfied me the most (based on output gradcams) implies a reduction of mask values. I did different tests and the resulting gradcams seem good.
Type of Change
Please select the one relevant option below:
Checklist
Please confirm that the following tasks have been completed:
Screenshots or Visuals (Optional)
If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.