Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix circular import making code not running properly #28

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: Fix circular import making code not running properly #28

merged 1 commit into from
Jul 18, 2023

Conversation

lorenzomammana
Copy link
Contributor

@lorenzomammana lorenzomammana commented Jul 18, 2023 •
edited
Loading

Summary

Fix circular import introduced with latest pr merge even tough tests were passing properly.

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana lorenzomammana added the bug Something isn't working label Jul 18, 2023
@rcmalli rcmalli merged commit f3ee8a4 into main Jul 18, 2023
@lorenzomammana lorenzomammana deleted the hotfix/circular-import branch July 18, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmalli rcmalli rcmalli approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzomammana @rcmalli