Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/git hyperparameter crash #46

Merged
merged 45 commits into from
Sep 8, 2023
Merged

Bugfix/git hyperparameter crash #46

merged 45 commits into from
Sep 8, 2023

Conversation

lorenzomammana
Copy link
Contributor

Summary

Right now we try to store the current commit inside the experiment hyperparameters for reproducibility, this causes an error when working inside of a git repository that doesn't contain any commit.

Resolves #26

Type of Change

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana
build: Add optional onnx dependencies
62d19bf
@lorenzomammana
feat: Add onnx export function
722aa1c
@lorenzomammana
refactor: Start logger refactoring
04b77ff
@lorenzomammana
feat: Add onnx export capabilities for classification
7dd3b0d
@lorenzomammana
feat: Add onnx export capability
2662aff
@lorenzomammana
wip: Improve onnx export code
e0d144d
@lorenzomammana
feat: Add evaluation model wrappers
deea036
@lorenzomammana
Merge branch 'dev' into feature/export-onnx-models
bbebc5f
@lorenzomammana
feat!: Refactor export_config parameter to become its own config to a…
a9104a4 
…void code replication
@lorenzomammana
refactor: Refactor export function to avoid excessive code replication
ac5e202
@lorenzomammana
feat: Add inference configuration
4a2b64c
@lorenzomammana
build: Upgrade anomalib version
f6eb7fe
@lorenzomammana
tests: Refactor anomaly tests to perform training and inference with …
4b63a4b 
…onnx and torchscript
@lorenzomammana
tests: Improve tests for classification related tasks
945c3c1
@lorenzomammana
tests: Update segmentation tests with onnx export
f3df848
@lorenzomammana
tests: Update ssl tests to integrate onnx export
b634890
@lorenzomammana
tests: Add tests to validate the outputs of exported models
b3cb29e
@lorenzomammana
build: Add pytest lazy fixtures package to test requirements
4e7beec
@lorenzomammana
Merge branch 'dev' into feature/export-onnx-models
a36b8b0
@lorenzomammana
tests: Add tests checking the equality of exported models outputs
8fa5a3d
@lorenzomammana
tests: Add guards to run tests if onnx is not installed, add onnx ins…
b79948b 
…tallation to github tests
@lorenzomammana
style: Fix wrong parentheses
c5d78fb
@lorenzomammana
fix: Fix wrong usage of pytest skipif
7756a4a
@lorenzomammana
fix: Fix missing parameter pop in export onnx function
79ade9b
@lorenzomammana
tests: Remove onnx export from fastflow test
52bbca2
@lorenzomammana
fix: Allow model wrapper to retrieve input shapes if instance is a to…
5b4ba4b 
…rchscript model
@lorenzomammana
build: Bump version 1.1.3 -> 1.1.4
4339897
@lorenzomammana
docs: Update changelog
b4253b6
@lorenzomammana
refactor: Tiny improvements to model export
23ec89b
@lorenzomammana
refactor: Add dictionary mapping export types and paths to model expo…
30cdaa6 
…rt function return values
lorenzomammana and others added 15 commits August 9, 2023 13:01
@lorenzomammana
Merge branch 'fix/model-wrapper-torchscript' into feature/export-onnx…
2eff1ca 
…-models
@lorenzomammana
fix: Fix defaults order
2d64f23
@lorenzomammana
refactor: Move get_export_extension function
a83c26c
@lorenzomammana
feat: Use iobinding to handle torch inputs for onnx
2bb94e9
@lorenzomammana
feat: Add cpu method to evaluation models
8972558
@lorenzomammana
fix: Fix wrong configuration parameter
15e1ee3
@lorenzomammana
fix: Fix segmentation analysis not working due to missing parameter
82c8319
@rcmalli
feat: add gpu unit tests
408d4e5
@lorenzomammana
docs: Add documentation for model import and export
48175b9
@lorenzomammana
docs: Add export information in documentation
e6ea4f7
@lorenzomammana
fix: Fix git information retrieval when working in a repository with …
e7727bd 
…no commits
@lorenzomammana
docs: Update changelog
bc682ff
@lorenzomammana
Merge branch 'feature/export-onnx-models' into bugfix/git-hyperparame…
34c2c7c 
…ter-crash
@lorenzomammana
docs: Update chagelog
be2d68d
@lorenzomammana
Merge branch 'dev' into bugfix/git-hyperparameter-crash
26550d8
@lorenzomammana lorenzomammana added the bug Something isn't working label Sep 8, 2023
@lorenzomammana lorenzomammana added this to the v1.2.0 milestone Sep 8, 2023
@lorenzomammana lorenzomammana self-assigned this Sep 8, 2023
@rcmalli rcmalli merged commit dbf4a2c into dev Sep 8, 2023
@lorenzomammana lorenzomammana mentioned this pull request Sep 8, 2023
Closed
@lorenzomammana lorenzomammana deleted the bugfix/git-hyperparameter-crash branch September 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmalli rcmalli rcmalli approved these changes

Assignees

@lorenzomammana lorenzomammana

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzomammana @rcmalli