Added docs about Merkle Tree #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoE11-y
approved these changes
May 27, 2023
chiro-hiro
reviewed
May 29, 2023
| Sparse Merkle Trees (SMTs) offer several benefits: | ||
|
|
||
| 1) **Efficiency**: They allow efficient storage of large, sparse datasets with minimal memory overhead. | ||
| 2) **Security**: Like traditional Merkle trees, they provide tamper-proof data structure and enable cryptographic verification of data integrity. |
There was a problem hiding this comment.
Does Sparse Merkle Tree have the same security issue with Merkle Tree?
There was a problem hiding this comment.
Yes, it does. It means if any unauthorized changes are made, they will be detected in the root.
There was a problem hiding this comment.
When I mentioned security issue, I meant Sparse Merkle Tree have the same Merkle Tree vulnerability that would lead to a false proof.
chiro-hiro
reviewed
May 29, 2023
| ### Ways to store Merkle Tree on IPFS | ||
| Here are different ways you could store a Merkle Tree on IPFS: | ||
|
|
||
| 1) **JSON Serialization**: One of the simplest ways to store a Merkle Tree in IPFS is to convert the Merkle Tree to a JSON structure and then save that to IPFS. This is a straightforward method but can be inefficient for large trees, as the entire tree needs to be retrieved even if you're only interested in certain parts of it. |
There was a problem hiding this comment.
Could we consider BSON and define a structure to store Merkle tree?
chiro-hiro
reviewed
May 29, 2023
| All standart merkle tree functions can be implemented along with these 'key' functions. | ||
|
|
||
| #### Zero nodes | ||
| For each level, zero nodes remain constant and can be generated during the initialization of the Merkle Tree. |
There was a problem hiding this comment.
Suggested change
| For each level, zero nodes remain constant and can be generated during the initialization of the Merkle Tree. | |
| For each level, zero nodes remain constant and can be generated during the initialization of the Merkle Tree. | |
Please format the code with MD formatter first.
|
Over all LGTM, just some minor issues need to be fixed and the security concern. |
magestrio
force-pushed
the
specs/merkle-tree
branch
from
000c56b to
573a515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature type
Feature description
Pull request checklist
Please check if your PR fulfills the following requirements: