Changes #4
Merged
Changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update isExists check to look for file status rather than looping through directory, this saves time - Fixed issues with getting poseidon hash, field was limited to 32 bytes, used the `Encoding.Bijective.Fp.fromBytes` method to pack bytes into the smallest number of field elements possible
|
Please give us a little more information in commit message or pull request title like, what is going to change?. |
|
This will be merged as soon as #2 was merged. |
chiro-hiro
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding.Bijective.Fp.fromBytesmethod to pack bytes from document into the smallest number of field elements possible.Feature type
Feature description
Pull request checklist
Please check if your PR fulfills the following requirements: