Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-types specification #6

Merged
merged 1 commit into from
May 6, 2023
Merged

data-types specification #6

merged 1 commit into from
May 6, 2023

Conversation

magestrio
Copy link
Contributor

Feature type

  • UI
  • Implementation
  • Specification
  • CI/CD
  • Other

Feature description

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Your code builds clean without any errors or warnings.
  • Tests for changes have been added (for bug fixes / features). If no, why?

iam-robi
iam-robi reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@iam-robi iam-robi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also good to explain in this section why we use bson

@JoE11-y JoE11-y merged commit 592fd57 into main May 6, 2023
@dqtkien dqtkien deleted the specification/data-types branch September 17, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iam-robi iam-robi iam-robi left review comments

@JoE11-y JoE11-y JoE11-y approved these changes

@chiro-hiro chiro-hiro Awaiting requested review from chiro-hiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magestrio @iam-robi @JoE11-y