Feature/ipfs storage engine #9
Conversation
There was a problem hiding this comment.
It is a best practice to put IO operations into the try-catch statements in order to be saved from race conditions.
There was a problem hiding this comment.
Try catch expression doesn't solve the race condition, in fact we need mutex and sync. Let's put this issue to backlog since it isn't urgent for now.
| const nodeP2p = await createLibp2p(config); | ||
| // Manual patch for node bootstrap | ||
| const addresses = [ | ||
| '/dnsaddr/bootstrap.libp2p.io/p2p/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN', |
There was a problem hiding this comment.
Would be cool to have hard-coded values as static constants to make them more meaningful.
There was a problem hiding this comment.
It's bootstrap nodes of IPFS, no need to make it configurable for now, and other people shouldn't care about this. Will add list off bootstrap nodes.
| const config: Libp2pOptions = { | ||
| start: true, | ||
| addresses: { | ||
| listen: ['/ip4/127.0.0.1/tcp/0'], |
There was a problem hiding this comment.
For example, here we can have the LOCAL_HOST constant
There was a problem hiding this comment.
Just like above reason, this value won't change. Passing a constant isn't free so i pass the value directly.
| '/dnsaddr/bootstrap.libp2p.io/p2p/QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb', | ||
| '/dnsaddr/bootstrap.libp2p.io/p2p/QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt', | ||
| ].map((e) => multiaddr(e)); | ||
| // Dial to bootstrap nodes |
There was a problem hiding this comment.
'Golden rule' to have a separate function instead of a comment
There was a problem hiding this comment.
It just call .dial() method, I don't think, we need another function here. Function cost a call frame so I don't prefer it.
Feature type
Feature description
Provide a module that allowed you to work with IPFS like, store, retrieve and BSON document to IPFS.
Pull request checklist
Please check if your PR fulfills the following requirements: