Merge pull request #523 from orottier/feature/rethrow-unit-test-proce…

…ssor-panics Rethrow panics in nodes during user tests
orottier · Sep 10, 2024 · 8502dec · 8502dec
2 parents 04da9b6 + 6adf77e
commit 8502dec
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/events.rs b/src/events.rs
@@ -191,6 +191,13 @@ impl EventLoop {
             result = ControlFlow::Break(());
         }
 
+        // In unit tests, we rethrow panics to avoid missing critical node exceptions
+        // https://github.com/orottier/web-audio-api-rs/issues/522
+        #[cfg(test)]
+        if let EventPayload::ProcessorError(e) = event.payload {
+            panic!("Rethrowing exception during tests: {:?}", e);
+        }
+
         let mut event_handler_lock = self.event_handlers.lock().unwrap();
         let callback_option = event_handler_lock.remove(&event.type_);
         drop(event_handler_lock); // release Mutex while running callback

diff --git a/src/node/waveshaper.rs b/src/node/waveshaper.rs
@@ -243,7 +243,7 @@ struct ResamplerConfig {
 
 impl ResamplerConfig {
     fn upsample_x2(channels: usize, sample_rate: usize) -> Self {
-        let chunk_size_in = RENDER_QUANTUM_SIZE * 2;
+        let chunk_size_in = RENDER_QUANTUM_SIZE;
         let sample_rate_in = sample_rate;
         let sample_rate_out = sample_rate * 2;
         Self {
@@ -255,7 +255,7 @@ impl ResamplerConfig {
     }
 
     fn upsample_x4(channels: usize, sample_rate: usize) -> Self {
-        let chunk_size_in = RENDER_QUANTUM_SIZE * 4;
+        let chunk_size_in = RENDER_QUANTUM_SIZE;
         let sample_rate_in = sample_rate;
         let sample_rate_out = sample_rate * 4;
         Self {
@@ -267,7 +267,7 @@ impl ResamplerConfig {
     }
 
     fn downsample_x2(channels: usize, sample_rate: usize) -> Self {
-        let chunk_size_in = RENDER_QUANTUM_SIZE;
+        let chunk_size_in = RENDER_QUANTUM_SIZE * 2;
         let sample_rate_in = sample_rate * 2;
         let sample_rate_out = sample_rate;
         Self {
@@ -279,7 +279,7 @@ impl ResamplerConfig {
     }
 
     fn downsample_x4(channels: usize, sample_rate: usize) -> Self {
-        let chunk_size_in = RENDER_QUANTUM_SIZE;
+        let chunk_size_in = RENDER_QUANTUM_SIZE * 4;
         let sample_rate_in = sample_rate * 4;
         let sample_rate_out = sample_rate;
         Self {
@@ -375,7 +375,7 @@ struct WaveShaperRenderer {
     upsampler_x2: Resampler,
     // up sampler configured to multiply by 4 the input signal
     upsampler_x4: Resampler,
-    // down sampler configured to divide by 4 the upsampled signal
+    // down sampler configured to divide by 2 the upsampled signal
     downsampler_x2: Resampler,
     // down sampler configured to divide by 4 the upsampled signal
     downsampler_x4: Resampler,
@@ -499,6 +499,7 @@ impl AudioProcessor for WaveShaperRenderer {
         if let Some(curve) = msg.downcast_mut::<Option<Vec<f32>>>() {
             std::mem::swap(&mut self.curve, curve);
 
+            // We can propagate silent input only if the center of the curve is zero
             self.can_propagate_silence = if let Some(curve) = &self.curve {
                 if curve.len() % 2 == 1 {
                     curve[curve.len() / 2].abs() < 1e-9