Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid false-positives for methods with no return #5

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Avoid false-positives for methods with no return #5

merged 2 commits into from
Feb 14, 2023

Conversation

orsinium
Copy link
Member

@orsinium orsinium commented Feb 13, 2023 •
edited
Loading

Do not annotate the return type as None for methods with the body like pass, ..., raise NotImplementedError etc. Such methods can be abstract base class definitions.

@orsinium orsinium changed the title WIP: Avoid false-positives for functions with no return Avoid false-positives for functions with no return Feb 14, 2023
@orsinium orsinium changed the title Avoid false-positives for functions with no return Avoid false-positives for methods with no return Feb 14, 2023
@orsinium orsinium merged commit f18d93d into master Feb 14, 2023
@orsinium orsinium deleted the better-no-return branch February 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orsinium