Update version #356
Merged
Update version #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Body.add_satellites_to_bodies_of_interest` will now silently handle any `SpiceSPKINSUFFDATA` errors if that `other_target_id` doesn't have an associated name in the SPICE kernels. This ensures that ID codes for non-existent satellites don't raise unneeded errors. This is basically equivalent to the previous (pre v1.10.0) behaviour, as before #352 any body without a defined name would raise a `NotFoundError` rather than a `SpiceSPKINSUFFDATA` error.
Make `add_satellites_to_bodies_of_interest` more permissive of SPICE errors
This ensures that if the bodies are the same, the `SpiceBODIESNOTDISTINCT` will be raised first (by the subpoint calculations), rather than potentially getting a more cryptic divide by zero error from the `target_diameter_arcsec` calculation. This shouldn't have any real change in runtime functionality, but should help to make things a little more explicit and clear.
Ensure `SpiceBODIESNOTDISTINCT` is raised first if the target and observer are the same
Pull Request Test Coverage Report for Build 9014719657Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
requirements.txtare reflected insetup.pyand conda-forge feedstockrun_ci.shor check GitHub Actions)See CONTRIBUTING.md for more details.