Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to choose between planetographic and planetocentric coordinates when plotting gridlines in the GUI #395

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ortk95
Copy link
Owner

@ortk95 ortk95 commented Aug 20, 2024

Added an option to the 'Edit' dialog for the gridlines in the GUI to allow the choice between planetographic and planetocentric coordinates. This means that it is now possible to create a plot using a planetocentric grid entirely using the GUI.

This is effectively adds the code changes made in #366 to the GUI. Along with the changes in #392, this brings full parity between planetographic and planetocentric coordinates in the GUI.

image

image

Closes #394

Pull request checklist

  • Add a clear description of the change
  • Add any new tests needed
  • Run spell check on new text visible to user (documentation, GUI etc.)
  • Check any changes to requirements.txt are reflected in setup.py and conda-forge feedstock
  • Check code passes CI checks (run run_ci.sh or check GitHub Actions)

See CONTRIBUTING.md for more details.

@ortk95 ortk95 changed the title Added option to have centric grid in GUI Add option to choose between planetographic and planetocentric coordinates when plotting gridlines in the GUI Aug 20, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10469982598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.617%

Totals Coverage Status
Change from base Build 10469569340: 0.0%
Covered Lines: 3157
Relevant Lines: 3169

💛 - Coveralls

@ortk95 ortk95 merged commit 3416946 into dev Aug 20, 2024
38 checks passed
@ortk95 ortk95 deleted the 394-centric-grid-option-in-gui branch August 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants