Check custom proj projection strings have the correct +axis=...
parameter before mapping
#398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom proj projection string is used when mapping, check the string's
+axis
parameter is consistent with the positive longitude direction of the body. I.e. positive west bodies should have+axis=wnu
and positive east bodies should have+axis=enu
. If the wrong+axis
parameter is used, then the output map is likely to be flipped and therefore incorrect, so PlanetMapper now raises aProjStringError
exception if the positive longitude direction and+axis
parameters are inconsistent.Also updated relevant documentation to suggest using
create_proj_string
, which automatically generates the correct+axis
parameter for the body.Closes #397
Pull request checklist
requirements.txt
are reflected insetup.py
and conda-forge feedstockrun_ci.sh
or check GitHub Actions)See CONTRIBUTING.md for more details.