Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add eslint rules #604

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Sep 28, 2023

I have added eslint with a set of recommended lint rules, and also fixed some bugs with the applied rules.
These will help improve development and maintain consistent code quality.

Proposed Changes

  • Added eslint and rules
  • Lint components

Mainly changed files are:

  • oruga-next/.eslintrc.cjs (add lint rules)
  • oruga-next/package.json (add eslint dependencies)
  • docs-next/docgen.config.js (fix docs)

@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality dependencies Pull requests that update a dependency file labels Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 5958afb
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/651545d0d496f3000815b571
😎 Deploy Preview https://deploy-preview-604--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title Add linter refactor: add eslint rules Sep 28, 2023
@mlmoravek mlmoravek marked this pull request as ready for review September 28, 2023 09:13
@mlmoravek mlmoravek requested a review from jtommy September 28, 2023 09:13
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (7db611c) 62.72% compared to head (7efc3c6) 62.34%.

❗ Current head 7efc3c6 differs from pull request most recent head 5958afb. Consider uploading reports for the commit 5958afb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #604      +/-   ##
===========================================
- Coverage    62.72%   62.34%   -0.38%     
===========================================
  Files           79       79              
  Lines         5529     5617      +88     
  Branches      1526     1576      +50     
===========================================
+ Hits          3468     3502      +34     
- Misses        1950     2004      +54     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 47.47% <48.97%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ackages/oruga-next/src/utils/BaseComponentMixin.ts 64.70% <ø> (-3.59%) ⬇️
packages/oruga-next/src/utils/CheckRadioMixin.ts 63.63% <ø> (ø)
packages/oruga-next/src/utils/FormElementMixin.ts 41.66% <ø> (-2.78%) ⬇️
packages/oruga-next/src/utils/MatchMediaMixin.ts 63.15% <ø> (ø)
packages/oruga-next/src/utils/config.ts 57.14% <ø> (+2.59%) ⬆️
packages/oruga-next/src/utils/helpers.ts 8.47% <ø> (-0.57%) ⬇️
packages/oruga-next/src/utils/icons.ts 90.90% <ø> (ø)
...es/oruga-next/src/components/collapse/Collapse.vue 89.47% <88.88%> (ø)
...es/oruga-next/src/components/checkbox/Checkbox.vue 73.91% <66.66%> (-2.28%) ⬇️
...ckages/oruga-next/src/components/button/Button.vue 72.50% <76.00%> (+2.22%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek self-assigned this Sep 28, 2023
@mlmoravek mlmoravek merged commit 33f2cd5 into oruga-ui:develop Sep 29, 2023
7 of 8 checks passed
@mlmoravek mlmoravek deleted the add-linter branch September 29, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant