Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update programmatic oruga #605

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Sep 29, 2023

I updated the programmatic interface for oruga by adding type definitions and usability enhancements.

Contains Breaking Changes

Proposed Changes

  • Added programmatic interface type definitions
  • Removed wrapping layer for programmatic interface
  • Changed useProgrammatic to useOruga

@mlmoravek mlmoravek added enhancement Improvements to existing features and functionality breaking Breaking changes labels Sep 29, 2023
@mlmoravek mlmoravek self-assigned this Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 65c9334
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65188da77412c6000899dd8b
😎 Deploy Preview https://deploy-preview-605--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (33f2cd5) 62.33% compared to head (65c9334) 62.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
- Coverage    62.33%   62.32%   -0.01%     
===========================================
  Files           79       79              
  Lines         5618     5622       +4     
  Branches      1576     1575       -1     
===========================================
+ Hits          3502     3504       +2     
- Misses        2005     2007       +2     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 47.44% <62.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/oruga-next/src/utils/config.ts 55.55% <62.50%> (-1.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtommy
Copy link
Member

jtommy commented Sep 29, 2023

I agree with you but it's a breaking change, so we can release it only on next 0.x version

@mlmoravek
Copy link
Member Author

I agree with you but it's a breaking change, so we can release it only on next 0.x version

Yeah, no need to merge it right away. We can wait until we have more for a major release update.

@mlmoravek mlmoravek merged commit e7bdb07 into oruga-ui:develop Oct 7, 2023
8 of 10 checks passed
@mlmoravek mlmoravek deleted the update-config branch October 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants