Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal content covered by background #82

Merged
merged 1 commit into from
May 5, 2023

Conversation

IlyaSemenov
Copy link
Contributor

Fix #78

@jtommy
Copy link
Member

jtommy commented May 5, 2023

@IlyaSemenov the problem is modal-card, following Bulma docs https://bulma.io/documentation/components/modal/#modal-card, it doesn't need that class

@IlyaSemenov
Copy link
Contributor Author

@jtommy But the base Bulma modal needs it (quoting the link above):

The modal structure is very simple:

  • modal: the main container
    • modal-background: a transparent overlay that can act as a click target to close the modal
    • modal-content: a horizontally and vertically centered container, with a maximum width of 640px, in which you can include any content
    • modal-close: a simple cross located in the top right corner

and o-modal is not supposed to be coupled with modal-card, is it?

@IlyaSemenov
Copy link
Contributor Author

From what I gathered, modal-card can live happily inside modal-content (that's how buefy worked anyway).

@jtommy jtommy merged commit a6fe94d into oruga-ui:master May 5, 2023
@jtommy
Copy link
Member

jtommy commented May 5, 2023

@IlyaSemenov thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal: Content is covered by background
2 participants