-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile checks for unneeded dependencies #1916
Comments
Right, I'm unfortunately not a Makefile wizard so if you have any ideas how to fix that I'm open to suggestions :) |
I'd imagine the right way to do it would be to have multiple `deps`, and
have different targets require different deps.
|
dalcde
added a commit
to dalcde/hydra
that referenced
this issue
Jun 19, 2020
This install dependencies only when you make a target that needs it. This also removes the check that certain system dependencies (e.g. go) are installed. Instead, we simply let the target fail. This ensures we only test for the desired dependencies. Fixes ory#1916
5 tasks
dalcde
added a commit
to dalcde/hydra
that referenced
this issue
Jun 19, 2020
This install dependencies only when you make a target that needs it. This also removes the check that certain system dependencies (e.g. go) are installed. Instead, we simply let the target fail. This ensures we only test for the desired dependencies. Fixes ory#1916
aeneasr
pushed a commit
that referenced
this issue
Jun 22, 2020
This install dependencies only when you make a target that needs it. This also removes the check that certain system dependencies (e.g. go) are installed. Instead, we simply let the target fail. This ensures we only test for the desired dependencies. Fixes #1916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Makefile
checks that dependencies for all possible targets are installed before running. This means if I only want tomake install-stable
, I still neednpm
anddocker-compose
installed.The text was updated successfully, but these errors were encountered: