possible #1615 solution: partial wildcard allowed-origins, with just …

[Aterocana]

…protocol specified (for example "http://*") could use glob ** pattern in order to match any sequence of characters (even the separator).

Signed-off-by: Aterocana <dominicimauriziogmail.com>

Related issue

@aeneasr as discussed in #1615 I'm proposing this fix.

Proposed changes

Basically I think the issue here is the protocol is specified, but no domain is: for example https://*.
Internally glob.Glob is compiled (with glob.Compile) with the provided string and '.' rune separator. Since g:=glob.Compile("https://*", '.') doesn't match g.Match("http://foobar.com") due to . separator, we could use g:=glob.Compile("https://**", '.') to ignore .` separator in this specific case.
In order to do so I simply tried to match if "://" substring is into an allowed-origin string.

Checklist

• I have read the contributing guidelines
• I have read the security policy
• I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
  vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation within the code base (if appropriate)
• I have documented my changes in the developer guide (if appropriate)

Further comments

[CLAassistant]

All committers have signed the CLA.

[aeneasr]

Awesome, thank you! Once the CLA is signed I'll merge this. Please comment once it's signed so I don't miss it!

[Aterocana]

Yeah, It seems I used a different mail from GitHub's one. Let me check tomorrow, if necessary I'll do a different pr.

[Aterocana]

I actually signed it, but it says I don't. Is it normal?

[aeneasr]

Hm, it says:

Maurizio Dominici seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

It also appears that your commit is not actually attributed to your GitHub account, as indicated by the greyed-out image:

To see how to link the local git commit to GitHub, here's a guide: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

Once the commit has the right metadata the toll should work :) Thank you!!

[Aterocana]

I'm closing this since I recreated the PR due to git user used. Sorry.